Refactor form verifiers API. #9798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvializ
changed the title
aghassemi
suggested changes
Jun 12, 2017
extensions/amp-form/0.1/amp-form.js
Outdated
| /** @const @private {?string} */ | ||
| this.xhrVerify_ = this.form_.getAttribute('verify-xhr'); | ||
| if (this.xhrVerify_) { | ||
| assertHttpsUrl(this.xhrVerify_, this.form_, 'verify-xhr'); |
There was a problem hiding this comment.
let's refactor to share validation logic between action-xhr and this.
extensions/amp-form/0.1/amp-form.js
Outdated
| this.form_.addEventListener('blur', e => { | ||
| checkUserValidityAfterInteraction_(dev().assertElement(e.target)); | ||
| this.validator_.onBlur(e); | ||
| }, true); | ||
|
|
||
| const cleanup = () => { |
There was a problem hiding this comment.
cleanup too generic given this methods deals with non-verifier code as well. Maybe afterVerifierCommit ?
extensions/amp-form/0.1/amp-form.js
Outdated
|
|
||
| /** | ||
| * Send a request to the form's verify endpoint. | ||
| * @private |
extensions/amp-form/0.1/amp-form.js
Outdated
| * @param {string} url | ||
| * @param {string} method | ||
| * @param {!Object<string, string>=} opt_extraFields | ||
| * @private |
| isDirty_() { | ||
| const form = this.form_; | ||
| for (let i = 0; i < form.elements.length; i++) { | ||
| const field = form.elements[i]; |
There was a problem hiding this comment.
I think we can break early for disable elements, they won't get submitted anyway.
aghassemi
approved these changes
Jun 12, 2017
jridgewell
reviewed
Jun 13, 2017
| isDirty_() { | ||
| const form = this.form_; | ||
| for (let i = 0; i < form.elements.length; i++) { | ||
| const field = form.elements[i]; |
There was a problem hiding this comment.
Whoo, this is going to be a slow loop. This'll recreate elements HTMLFormControlsCollection on every iteration.
There was a problem hiding this comment.
Ah I didn't consider it'd be computed every access. I'll cache it in a variable outside the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the suggestions @dvoytenko gave for the form verification API.
verify-xhrattribute functioning similarly toaction-xhrchangeevent. The groups allowed us to limit the requests to only send when a group was completeCloses #9696