Finally, fix visState integration tests #9806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I verified this by running multiple browsers against the tests.
rsimha
approved these changes
Jun 8, 2017
| }); | ||
|
|
||
| it('calls layout when going to VISIBLE', () => { | ||
| viewer.receiveMessage('visibilitychange', | ||
| {state: VisibilityState.VISIBLE}); |
There was a problem hiding this comment.
nit: indent += 2 (here, and all other calls to viewer.receiveMessage())
alanorozco
added a commit
that referenced
this pull request
Jun 9, 2017
This reverts commit 47f9191.
erwinmombay
pushed a commit
that referenced
this pull request
Jun 9, 2017
* Revert "Add a caches.json file that provides meta data about AMP Caches. (#9804)" This reverts commit 55a3ac0. * Revert "Fix flaky amp-animation test (#9817)" This reverts commit 4a9cf91. * Revert "Run integration tests for PRs that change `test/integration` (#9807)" This reverts commit 233c76e. * Revert "Finally, fix visState integration tests (#9806)" This reverts commit 47f9191. * Revert "add jwt plugin (#8672)" This reverts commit a23cbd1. * Revert "Add missing methods to AmpContext tests (#9682)" This reverts commit 646f103.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I verified this by running multiple browsers against the tests.