Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix visState integration tests, Part 2 #9815

Merged
merged 2 commits into from Jun 9, 2017
Merged

Fix visState integration tests, Part 2 #9815

merged 2 commits into from Jun 9, 2017

Conversation

jridgewell
Copy link
Contributor

@jridgewell jridgewell commented Jun 9, 2017 •
edited

Fixes #9757 (finally?).

@jridgewell
Copy link
Contributor Author

Tests are failing due to #9814.

rsimha
rsimha approved these changes Jun 9, 2017
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that all remaining failures in https://travis-ci.org/ampproject/amphtml/jobs/241031346 are due to #9814?

If so, you'll need to force merge either this PR, or the fix to #9814.

@alanorozco
Copy link
Member

alanorozco commented Jun 9, 2017 •
edited

Offending PR has been reverted: #9819

Edit: Should be #9820
Edit 2: It's in.

@rsimha rsimha merged commit 73bb468 into ampproject:master Jun 9, 2017
@jridgewell jridgewell deleted the fix-vis-state-integration-tests-2 branch June 9, 2017 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelburrito camelburrito camelburrito approved these changes

@rsimha rsimha rsimha approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jridgewell @alanorozco @camelburrito @rsimha @googlebot @ampprojectbot