New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
amp-sidebar: optional attribute to change text for screen-reader clos… #9958
Merged
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
2cc99bc
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai 8564790
revert packagge.json
rhapsodyai 5748c3e
revert src/service/platform-impl.js
rhapsodyai 12e9e34
revert yarn.lock to previous commit
rhapsodyai 3eb5802
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai 15f4d33
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai 06fc212
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai 5854b73
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai be63235
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai 20e32a7
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai e3f7a4a
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai 8b4d4b5
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai db2dc78
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai b53ff75
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai 465c67a
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai 07e5d87
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai ee895b4
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai bb300da
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai 230a483
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai aaae345
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai 2f9fdac
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai 7446b4d
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai c92a4bd
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai f296c69
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai 0c21838
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai 65f7886
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai c375d7f
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai 4ac242a
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai 91fe36b
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai 28f6a2c
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai ec91297
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai d19031f
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai d99be68
amp-sidebar: optional attribute to change text for screen-reader clos…
rhapsodyai File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -68,6 +68,16 @@ describes.realWin('amp-sidebar 0.1 version', { | |
return {iframe, ampSidebar}; | ||
}); | ||
}); | ||
|
||
it('should replace text to screen reader \ | ||
button in data-close-button-aria-label', () => { | ||
return getAmpSidebar().then(obj => { | ||
if (options.closeText) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this part needs to move to the
|
||
ampsetbar.setAttribute('data-close-button-aria-label', options.closeText); | ||
}; | ||
expect(closeButton.textContent).to.equal(options.closeText); | ||
}); | ||
}); | ||
} | ||
|
||
beforeEach(() => { | ||
|
@@ -129,16 +139,6 @@ describes.realWin('amp-sidebar 0.1 version', { | |
}); | ||
}); | ||
|
||
it('should replace text to screen reader \ | ||
button in data-close-button-aria-label', () => { | ||
return getAmpSidebar().then(obj => { | ||
if (options.closeText) { | ||
ampsetbar.setAttribute('data-close-button-aria-label', options.closeText); | ||
}; | ||
expect(closeButton.textContent).to.equal(options.closeText); | ||
}); | ||
}); | ||
|
||
it('should open sidebar on button click', () => { | ||
return getAmpSidebar().then(obj => { | ||
const sidebarElement = obj.ampSidebar; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,6 +69,16 @@ | |
return {iframe, ampSidebar}; | ||
}); | ||
}); | ||
|
||
it('should replace text to screen reader \ | ||
button in data-close-button-aria-label', () => { | ||
return getAmpSidebar().then(obj => { | ||
if (options.closeText) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here. |
||
ampsetbar.setAttribute('data-close-button-aria-label', options.closeText); | ||
}; | ||
expect(closeButton.textContent).to.equal(options.closeText); | ||
}); | ||
}); | ||
} | ||
|
||
beforeEach(() => { | ||
|
@@ -131,16 +141,6 @@ | |
}); | ||
}); | ||
|
||
it('should replace text to screen reader \ | ||
button in data-close-button-aria-label', () => { | ||
return getAmpSidebar().then(obj => { | ||
if (options.closeText) { | ||
ampsetbar.setAttribute('data-close-button-aria-label', options.closeText); | ||
}; | ||
expect(closeButton.textContent).to.equal(options.closeText); | ||
}); | ||
}); | ||
|
||
it('should open sidebar on button click', () => { | ||
return getAmpSidebar().then(obj => { | ||
const sidebarElement = obj.ampSidebar; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These next 3 lines sill need to be moved inside
getAmpSidebar
.