Depend on validator.pb.go from amphtml project. #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twifkak
force-pushed
the
amp_validator
branch
from
56a562a
to
9ece13d
Compare
alin04
reviewed
Sep 13, 2018
|
This is covered by #92. |
twifkak
force-pushed
the
amp_validator
branch
from
9ece13d
to
6745351
Compare
This is a follow-up to bbfdb11 (ampproject#92) to pull the needed dependency into vendor/, and remove the unused file in pkg/. Also, add `prune.non-go = true` to Gopkg.toml, to eliminate a bunch of unnecessary files in vendor/.
twifkak
force-pushed
the
amp_validator
branch
from
6745351
to
2ab9e8d
Compare
|
PTAL - This is what's leftover from #92, and no longer covers |
|
Fixes #28. |
alin04
approved these changes
Sep 13, 2018
|
That's in this commit; it just shows up as a rename. See https://github.com/ampproject/amppackager/pull/88/files#diff-94ee56b283d614195a3f7fd45652a572 or https://github.com/ampproject/amppackager/pull/88.patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the remaining file in pkg/. Also, add
prune.non-go = trueto Gopkg.toml, to eliminate a bunch of unnecessary files in vendor/.
Addresses #28.