-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/modernize bitset #634
Feature/modernize bitset #634
Conversation
Was there an existing test for this? |
https://github.com/squaremo/amqp.node/blob/main/test/bitset.js i run the test, everything passed |
You mean the one in /test, right? Maybe we should touch it up a bit to use newer syntax as well? |
yea, sry, copied the wrong link - changed it sure, i was doing quite a large commit to modernize all files but then i realized it was a bit to much to review. so i basically take one file at the time/PR |
modernized the test file as well. |
LGTM! |
Test result
|
It might make sense to consider adding GitHub Actions for proper CI, looks like Travis is broken again. |
related? |
Super, so nice to see up-to-date syntax. Thank you! |
No description provided.