-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
detach without network activity possible... #66
Comments
What happens to the state of the connection and session containing the link? Would forcing a disconnect work for example? |
We call this only when the connection is already down. We're just trying to clean up. Depending on whether we are retrying operations, we would subsequent to this, be trying to open up the connection again and creating new sessions and links. |
So the idea is to prevent the link being reattached automatically when the connection reconnects? |
Essentially. We're also trying to clean up in the hopes that the objects representing this link will get gc'd away. |
Although, you also raise the interesting point, that I would probably want something similar for the session I opened. I would be recreating that also. |
Ok, understood. |
I've created a PR with a suggested change: #68. It adds a remove() method to link and session that can be used to clean them up if desired. Does that look like what you need? |
Utilizing the amqp10 library the links had a method called forceDetach.
We found it useful when doing error recovery to invoke on link. Essentially it caused the local state of the link to go to detached without actually performing a network operation to inform the remote. This is helpful when having detected an actual networking issue, we no longer wish to perform network operations that we know will fail.
Is there anyway that we can mimic this activity with rhea? In cursory looking at detach, it does look like that it will initiate a network send.
Thank you for your time,
Tony
The text was updated successfully, but these errors were encountered: