Slab reinforcement improvements #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds detailing functions for L-Shape, U-Shape, Bent shape, Straight rebars for slab reinforcement - Fixed default value of orientation in makeBentShapeRebar
- adds typing annotations for arguments of makeSlabReinforcement
- adds different combinataion of Straight, U-Shaped, L-Shaped, BentShaped rebars for parallel and cross rebars in Slab Reinforcement. - format Rebarfunc.py using black.
- add "Left", "Right" and "Alternate" orientation to LShapeRebar hook
- add distribution rebars for slab spaning in one/two direction - improve bent arms sepration for bent shape rebars
- prevent collision of distribution rebar with an angled arm of bent shape rebar (due to varying angle) by adding bent shape rebar diameter in front/rear cover of distribution rebars.
- add layout files for making slab reinforcement - add integration of UI with python api for making slab reinforcement
- remove seperate distribution rebars tabs for parallel and cross rebars - add distribution rebars fields in main cross/parallel ui pages
- add Slab Reinforcement Rebars grouping - add support to edit Slab Reinforcement directly from properties panel in FreeCAD - update makeSlabReinforcement funnction to support SlabReinforcementGroup
- add editSlabReinforcement to edit Slab Reinforcement - add _SlabReinforcementViewProviderGroup class to enable double click on SlabReinforcement object - add editDialog and set value function for different type of rebars in Slab Reinforcement to integrate edit reinforcement in UI
- add check for none value of parameter's of make/edit slab reinforcement functions - assigned fixed size to slab reinforcement dropdown
|
This PR's changes are merged in PR #164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reinforcement functions