Change effective cover to clear cover #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Add rebars to a group - Store properties like HookOrientation, HookExtendAlong to group under Rebar Dialog - Add temporary icon for column reinforcement item in drop down menu
Changes: - Create class for group of rebars. - Implement double click on group object in tree view will open dialog box to edit created reinforcement.
Changes: - Now double clicking on group of rebars in tree view will open a dialog box and set values in UI to the values entered by user while creating reinforcement - Fix error: <class 'TypeError'>: Object of type FeaturePython is not JSON serializable - Define function __getstate__() and __setstate__() in class _ViewProviderRebarGroup in file Rebarfunc.py to fix above error - Solution reference: https://forum.freecadweb.org/viewtopic.php?t=33486#p280368
Changes: - Create class SingleTieFourRebars in file SingleTie.py by inheriting class _RebarGroup and _ViewProviderRebarGroup from file Rebarfunc.py - Define __init__() function in class SingleTieFourRebars to create group for rebars and add properties to it - Rename function addGroupData() to setProperties() and move from file SingleTie.py to class _RebarGroup - Create function setPropertiesValues() in class _RebarGroup to store values of created reinforcement in group SingleTieFourRebars
Changes: - Add diameter/2 to left/right/top/bottom/front cover, wherever required. - Now, user can input clear cover instead of effective cover in Rebar Dialog box.
Changes: - Modify function makeSingleTieFourRebars() to calculate clear cover instead of effective cover. Changes are necessary due to modification in base functionality of Rebar Addon as of commit: 22d20d3
Modify function makeSingleTieFourRebars() to accept Left/Right/Top/Bottom cover instead of only x-direction and y-direction cover. This will give more flexibility to user to specify cover of tie.
Now, user can specify Left, Right, Top and Bottom cover of Tie instead of only x-direction and y-direction cover in UI.
Issue: When cover top/left cover of Tie is greater than bottom/right cover of Tie, then rebars start overlapping Tie. Example image: https://imgur.com/KM1dNAb Solution: set OffsetEnd = t_cover_of_tie + dia_of_tie + dia_of_rebars / 2 Or OffsetEnd = l_cover_of_tie + dia_of_tie + dia_of_rebars / 2 as per requirements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.