Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of bank select - LSB instead of MSB #190

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nickdowell
Copy link
Member

amsynth was incorrectly ignoring the MIDI bank select LSB (CC20) and treating the MSB (CC0) as the back number (as sent by vkeybd)

Verified fix using jack-keyboard.

Addresses issue raised in #35 (comment)

@codecov
Copy link

codecov bot commented Apr 11, 2021

Codecov Report

Merging #190 (d101d99) into develop (a8e78a9) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #190      +/-   ##
===========================================
+ Coverage    34.19%   34.23%   +0.03%     
===========================================
  Files           53       53              
  Lines         3193     3190       -3     
===========================================
  Hits          1092     1092              
+ Misses        2101     2098       -3     
Impacted Files Coverage Δ
src/MidiController.cpp 55.23% <0.00%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e78a9...d101d99. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant