Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump Nushell and Nupm #140

Merged
merged 14 commits into from
Dec 15, 2023
Merged

bump Nushell and Nupm #140

merged 14 commits into from
Dec 15, 2023

Conversation

amtoine
Copy link
Owner

@amtoine amtoine commented Dec 15, 2023 •
edited
Loading

this PR

full changelog

  • move the src/nu-git-manager/ module to pkgs/nu-git-manager/nu-git-manager/
  • move the src/nu-git-manager-sugar/ module to pkgs/nu-git-manager/nu-git-manager-sugar/
  • split package.nuon into pkgs/nu-git-manager/package.nuon and `pkgs/nu-git-manager-sugar/package.nuon
  • fix all the imports, especially in the tests
  • fix the install-package test of nu-git-manager
  • clone the install-package test from nu-git-manager to nu-git-manager-sugar
  • fix the listing of modules in the toolkit

TODO

@amtoine amtoine added the ci Something related to the Continuous Integration label Dec 15, 2023
@amtoine amtoine marked this pull request as draft December 15, 2023 12:33
@amtoine amtoine added the refactor Changes that just moves code around without altering features label Dec 15, 2023
This was referenced Dec 15, 2023
Merged
Merged
@amtoine
Merge branch 'main' into bump-nushell-and-nupm
4bab0d9 
this should fix the CI of #140 thanks to #135.
@amtoine amtoine marked this pull request as ready for review December 15, 2023 15:07
@amtoine amtoine merged commit 529ff39 into main Dec 15, 2023
5 checks passed
@amtoine amtoine deleted the bump-nushell-and-nupm branch December 15, 2023 15:21
amtoine added a commit that referenced this pull request Dec 15, 2023
@amtoine
Merge branch 'nightly' into fix-manual-export
d667cb2 
this should solve the merge conflict in #134 and bring the changes
from #140.
amtoine added a commit that referenced this pull request Dec 15, 2023
@amtoine
fix the export of modules (#134)
1262909 
depends on
- nushell/nushell#11157
- nushell/nupm#47
- #140
- #141

## description
as directory modules won't export the modules next to any `mod.nu`, this
PR adds `export module` calls to `nu-git-manager-sugar` and the tests,
making the source base compatible again with
nushell/nushell#11157 and
nushell/nupm#47.
@amtoine amtoine mentioned this pull request Dec 15, 2023
Merged
kubouch pushed a commit to nushell/nupm that referenced this pull request Dec 17, 2023
@amtoine
update the index (#54)
bf17351 
related to
- #50
- amtoine/nu-git-manager#140
- nushell/nu_scripts#700

## Description
#50 forces some packages with multiple modules to be split into multiple
packages.
this is the case of `amtoine/nu-git-manager` and `nushell/nu_scripts`
and this PR reflects this new set of packages.

> **Note**
> the script given as an example in
#49 might not work for now with the
ongoing transition from `package.nuon` to `nupm.nuon` in
#49
amtoine added a commit that referenced this pull request Jan 21, 2024
@amtoine
fix the export of modules (#134)
f359ced 
depends on
- nushell/nushell#11157
- nushell/nupm#47
- #140
- #141

## description
as directory modules won't export the modules next to any `mod.nu`, this
PR adds `export module` calls to `nu-git-manager-sugar` and the tests,
making the source base compatible again with
nushell/nushell#11157 and
nushell/nupm#47.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci Something related to the Continuous Integration refactor Changes that just moves code around without altering features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@amtoine