Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export internal modules manually #47

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented Dec 9, 2023

related to

Description

this will export the install and test modules publicly from nupm.

@amtoine amtoine added the wait-for-upstream Need changes from an upstream dependency label Dec 11, 2023
@kubouch kubouch marked this pull request as ready for review December 13, 2023 20:35
@kubouch
Copy link
Contributor

kubouch commented Dec 13, 2023

Let's merge it since the upstream PR is going in.

@kubouch kubouch merged commit 7d34b83 into nushell:main Dec 13, 2023
3 checks passed
@amtoine amtoine deleted the fix-manual-export branch December 13, 2023 21:01
amtoine added a commit to amtoine/nu-git-manager that referenced this pull request Dec 15, 2023
depends on
- nushell/nushell#11157
- nushell/nupm#47
- #140
- #141

## description
as directory modules won't export the modules next to any `mod.nu`, this
PR adds `export module` calls to `nu-git-manager-sugar` and the tests,
making the source base compatible again with
nushell/nushell#11157 and
nushell/nupm#47.
amtoine added a commit to amtoine/nu-git-manager that referenced this pull request Jan 21, 2024
depends on
- nushell/nushell#11157
- nushell/nupm#47
- #140
- #141

## description
as directory modules won't export the modules next to any `mod.nu`, this
PR adds `export module` calls to `nu-git-manager-sugar` and the tests,
making the source base compatible again with
nushell/nushell#11157 and
nushell/nupm#47.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wait-for-upstream Need changes from an upstream dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants