Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample presto view data for quick start #61

Closed
feng-tao opened this issue May 7, 2019 · 5 comments
Closed

Add sample presto view data for quick start #61

feng-tao opened this issue May 7, 2019 · 5 comments
Labels
keep fresh Disables stalebot from closing an issue

Comments

@feng-tao
Copy link
Member

feng-tao commented May 7, 2019

@youngyjd provides a presto view extractor in https://github.com/lyft/amundsendatabuilder/pull/25/files. We should provide sample presto view data for quick start documentation.

@feng-tao
Copy link
Member Author

feng-tao commented May 7, 2019

cc @youngyjd in case you have bandwidth. And the issue is a good starter for a project newcomer.

@ttannis ttannis transferred this issue from amundsen-io/amundsendatabuilder Aug 7, 2019
@stale
Copy link

stale bot commented Aug 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Aug 16, 2019
@feng-tao feng-tao removed the stale label Aug 16, 2019
@dschaller dschaller added the keep fresh Disables stalebot from closing an issue label Aug 17, 2019
jakemongaya pushed a commit to jakemongaya/amundsen that referenced this issue Dec 11, 2019
…n-io#61)

* [amundsen-io#60]: Fixes paging over dataset and column count

* Update setup.py
@jornh
Copy link
Contributor

jornh commented Mar 4, 2020

@feng-tao, the Quickstart now has a view, even though it’s just feed from the CSVs: https://github.com/lyft/amundsendatabuilder/blob/v2.1.0/example/sample_data/sample_col.csv#L11 and https://github.com/lyft/amundsendatabuilder/blob/v2.1.0/example/sample_data/sample_table.csv#L4 which also sets the is_view flag.

Does this resolve this issue or do you want something more specific?

@feng-tao
Copy link
Member Author

feng-tao commented Mar 4, 2020

I am the issue could be closed now.

@feng-tao feng-tao closed this as completed Mar 4, 2020
@rqmulti
Copy link

rqmulti commented May 6, 2020

i dont know if is it important but could be nice for the comunity samples of dags and script implementing the extractors.

dorianj pushed a commit to dorianj/amundsen that referenced this issue Apr 25, 2021
…n-io#61)

* [amundsen-io#60]: Fixes paging over dataset and column count

* Update setup.py
dorianj pushed a commit to dorianj/amundsen that referenced this issue Apr 25, 2021
* fix for issue 106

* bumping minor version for issue 106
feng-tao pushed a commit that referenced this issue May 7, 2021
* [#60]: Fixes paging over dataset and column count

* Update setup.py
feng-tao pushed a commit that referenced this issue May 7, 2021
* fix for issue 106

* bumping minor version for issue 106
m1racoli pushed a commit to m1racoli/amundsen that referenced this issue Mar 23, 2022
zacr pushed a commit to SaltIO/amundsen that referenced this issue May 13, 2022
* fix for issue 106

* bumping minor version for issue 106
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this issue Jun 30, 2022
…n-io#61)

* [amundsen-io#60]: Fixes paging over dataset and column count

* Update setup.py
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this issue Jun 30, 2022
* fix for issue 106

* bumping minor version for issue 106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep fresh Disables stalebot from closing an issue
Projects
None yet
Development

No branches or pull requests

5 participants