fix: Handle qualified tableau datasources more gracefully #1869
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
When unpacking tableau datasources, if a table reference had more than two parts (i.e.
database.schema.table
rather than justtable
orschema.table
) this would raise aKeyError
during unpacking and the script would stop abruptly.This fix adds handling code for greater degrees of qualification and also a graceful path for dbapis which have potentially very long qualification options (e.g.
foo.bar.baz.db.schema.table
). I haven't accounted for anything more specific that something that will work for now, although that would be something that could be built on at a later date. This solution solves for the most common use case where the database may be qualified in the table reference.Tests
No tests added as I don't believe there is an existing test which could be extended to cover this case. I'm still new to the codebase to any pointers on a sensible test to add would be excellent and I'm happy to implement one.
Documentation
No documentation added - I believe this should be the expected behaviour.
CheckList
Make sure you have checked all steps below to ensure a timely review.