Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hive metadata extractor not work on postgresql #394

Merged
merged 2 commits into from Oct 28, 2020

Conversation

zhmin
Copy link
Contributor

@zhmin zhmin commented Oct 27, 2020

Signed-off-by: zhmin myzhmin@gmail.com

Summary of Changes

Include a summary of changes then remove this line

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Signed-off-by: zhmin <myzhmin@gmail.com>
@allisonsuarez
Copy link
Contributor

There are some unit tests failing, make sure to also write some tests for the behavior you are adding.

@feng-tao
Copy link
Member

the unit test seems to fail as well as DCO fail (https://github.com/amundsen-io/amundsendatabuilder/pull/394/checks?check_run_id=1318680814)

@zhmin zhmin force-pushed the master branch 4 times, most recently from e4ccb02 to e882062 Compare October 28, 2020 05:55
Signed-off-by: zhmin <myzhmin@gmail.com>
@zhmin
Copy link
Contributor Author

zhmin commented Oct 28, 2020

unit test error has been fixed

@feng-tao
Copy link
Member

thanks

@feng-tao feng-tao merged commit 2992618 into amundsen-io:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants