Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Address PyAthena dependency problem #429

Merged
merged 1 commit into from Dec 17, 2020

Conversation

Akeboshiwind
Copy link
Contributor

Summary of Changes

As seen here: laughingman7743/PyAthena#189
The 2.0.0 version of PyAthena doesn't install SQLAlchemy for some reason
This PR fixes that

This issue can be reproduced in a similar way to the linked Issue:

$ mkdir /tmp/test
$ cd /tmp/test
$ python3 -m venv venv
$ source venv/bin/activate
(venv) $ echo 'amundsen-databuilder[athena]==4.0.3' > requirements.txt
(venv) $ pip3 install -r requirements.txt 2>/dev/null | grep Ignoring
  Ignoring sqlalchemy: markers 'extra == "SQLAlchemy"' don't match your environment

This fix just ignores version 2.0.0 for now, presumably until that dependency issue is fixed.

Tests

As this is a dependency issue I don't think there's a test that can be run 🤷‍♂️

CheckList

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

The make test fails for me. But that "shouldn't" be because of this dep change, I would guess more likely a setup issue :/.

As seen here: laughingman7743/PyAthena#189
The 2.0.0 version of PyAthena doesn't install SQLAlchemy for some reason
This PR fixes that
@feng-tao feng-tao merged commit 7157c24 into amundsen-io:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants