fix: Address PyAthena dependency problem #429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
As seen here: laughingman7743/PyAthena#189
The 2.0.0 version of PyAthena doesn't install SQLAlchemy for some reason
This PR fixes that
This issue can be reproduced in a similar way to the linked Issue:
This fix just ignores version 2.0.0 for now, presumably until that dependency issue is fixed.
Tests
As this is a dependency issue I don't think there's a test that can be run 🤷♂️
CheckList
make test
The
make test
fails for me. But that "shouldn't" be because of this dep change, I would guess more likely a setup issue :/.