Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLAlchemy dependency ignored when installing 2.0.0 #189

Closed
Akeboshiwind opened this issue Dec 17, 2020 · 4 comments
Closed

SQLAlchemy dependency ignored when installing 2.0.0 #189

Akeboshiwind opened this issue Dec 17, 2020 · 4 comments

Comments

@Akeboshiwind
Copy link

This is easiest to show with an example:

$ mkdir /tmp/test
$ cd /tmp/test
$ python3 -m venv venv
$ source venv/bin/activate
(venv) $ echo 'PyAthena[SQLAlchemy]>=2.0.0' > requirements.txt
(venv) $ pip3 install -r requirements.txt 2>/dev/null | grep Ignoring
  Ignoring sqlalchemy: markers 'extra == "SQLAlchemy"' don't match your environment

As you can see, SQLAlchemy isn't installed if you specify the "SQLAlchemy" extra on 2.0.0.

I've confirmed that this isn't an issue if I specify PyAthena[SQLAlchemy]==1.11.2 instead.

Akeboshiwind added a commit to ake-forks/amundsendatabuilder that referenced this issue Dec 17, 2020
As seen here: laughingman7743/PyAthena#189
The 2.0.0 version of PyAthena doesn't install SQLAlchemy for some reason
This PR fixes that
feng-tao pushed a commit to amundsen-io/amundsendatabuilder that referenced this issue Dec 17, 2020
As seen here: laughingman7743/PyAthena#189
The 2.0.0 version of PyAthena doesn't install SQLAlchemy for some reason
This PR fixes that
@laughingman7743
Copy link
Owner

Thanks, I guess the change of package manager to Poetry from 2.0.0 has an effect.
I will investigate.

@Akeboshiwind
Copy link
Author

Akeboshiwind commented Dec 18, 2020 via email

@laughingman7743
Copy link
Owner

pypa/pip#4617 👀

@laughingman7743
Copy link
Owner

I uploaded version 2.0.1 of the following branch to test.pypi.org.
#191
https://test.pypi.org/project/pyathena/2.0.1/

I installed it to try it out and it seemed to work fine :)
Please check it out.

laughingman7743 added a commit that referenced this issue Dec 25, 2020
Convert extras names to lowercase (fix: #189)
dorianj pushed a commit to dorianj/amundsen that referenced this issue Apr 25, 2021
As seen here: laughingman7743/PyAthena#189
The 2.0.0 version of PyAthena doesn't install SQLAlchemy for some reason
This PR fixes that
feng-tao pushed a commit to amundsen-io/amundsen that referenced this issue May 7, 2021
As seen here: laughingman7743/PyAthena#189
The 2.0.0 version of PyAthena doesn't install SQLAlchemy for some reason
This PR fixes that
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this issue Jun 30, 2022
As seen here: laughingman7743/PyAthena#189
The 2.0.0 version of PyAthena doesn't install SQLAlchemy for some reason
This PR fixes that
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants