-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setup.py script to fix installation issue #85
Conversation
This looks good to me, as with the |
67236c2
to
7f70389
Compare
@verdan will do once I get a +1. Will ping you once I do a push to pypi. |
Some initial context:
More context on what the goal is would be helpful in order to know how to move forward. |
I think the use case is to build js and python code together when running
python setup.py. We don’t need to run the npm under static dir.
On Wed, Apr 17, 2019 at 10:11 AM Tamika Tannis ***@***.***> wrote:
Some initial context: is_npm_installed() and build_js() methods were a
part of some experimental code when I was initially investigating how to
manage the fact that we needed to build assets with npm commands yet
generate a working python package. Upfront:
1. These methods should have been deleted
2. I saw some comment in a previous PR about wanting the built assets
in the dist to be included in the python package? If so, the intent
here is that users are still supposed to be running npm install and npm
run build in their own local environments to generate the application
source.
More context on what the goal is would be helpful in order to know how to
move forward.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#85 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADEuOpxgmXKItsUw4JXEaN5oOnmHmxhgks5vh1XQgaJpZM4c0KIZ>
.
--
*Tao Feng*
Software Engineer
608-770-9552
|
@ttannis, the use case is to run the amundsen project using https://amundsenworkspace.slack.com/archives/CGFBVT23V/p1555522967029000 |
It is probably smart to keep an eye on the Licenses of the dependencies you are pulling in (npm and pip) and making part of the package. The pro of building locally is that you are not redistributing which could complicate things for example in case of GPLed libs. |
@verdan v.1.0.2 has been released. |
thanks @jinhyukchang |
I encountered the same issue mentioned by @verdan in #82 with a fresh checkout of the repo. The issue seems to be related to using
npm install --only==prod
.I don't have much context as @danwom and @ttannis on this flag. My understanding is to save the build size to reduce page load time? But I don't think page load time is really an issue with the tool.
Per heartsucker/node-deb#15 , it will skip installing those devDependencies listed in package.json.
By removing the
--only==prod
, thepython setup.py install
command works at my local setup.