Ammending meson.build files to fix linking issue - issue38 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
louisharris
approved these changes
Aug 1, 2023
loganek
reviewed
Aug 1, 2023
| @@ -15,7 +15,7 @@ symbol_export_define = ['-DGST_EXPORTS'] | |||
|
|
|||
| credentials = library('gstawscredentials-@0@'.format(apiversion), | |||
| ['gstawscredentials.cpp'], | |||
| dependencies : [aws_cpp_sdk_sts_dep, gst_dep], | |||
| dependencies : [aws_cpp_sdk_sts_dep, gst_dep, aws_c_common_dep, aws_crt_cpp_dep], | |||
There was a problem hiding this comment.
just out of curiosity; why is that needed? isn't it an implicit dependency of aws-cpp-sdk-sts?
There was a problem hiding this comment.
I’ve spoken with the engineer who requested this, and they advised it's because they're building with yocto for embedded. They tried to rebuild without the dependencies, and it still fails. For context this is where they have their patch in their repo.
There was a problem hiding this comment.
We have an open issue with the AWS SDK to investigate this see aws/aws-sdk-cpp#2643
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.