Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write documentation on modifications via JS property files #159

Closed
chazzmoney opened this issue Oct 5, 2018 · 3 comments
Closed

Write documentation on modifications via JS property files #159

chazzmoney opened this issue Oct 5, 2018 · 3 comments
Assignees
@dbanksdesign
Labels
chore documentation
Projects
SD 3.0
Milestone
3.0

Comments

@chazzmoney
Copy link
Collaborator

chazzmoney commented Oct 5, 2018 •
edited

People seem to want this still, so we should either build it in or write up some very clear documentation on how to go about using JS property files to do this.

#59, #120 both were related to this.
@chazzmoney chazzmoney created this issue from a note in SD 3.0 (To do) Oct 5, 2018
@chazzmoney chazzmoney changed the title Either add modifiers or write documentation on modifications via JS properties Either add modifiers or write documentation on modifications via JS property files Oct 5, 2018
@chazzmoney chazzmoney mentioned this issue Oct 5, 2018
Closed
@chazzmoney chazzmoney added this to the 3.0 milestone Oct 5, 2018
@chazzmoney
Copy link
Collaborator Author

We have an example here:
https://github.com/amzn/style-dictionary/tree/master/examples/advanced/node-modules-as-config-and-properties

@chazzmoney
Copy link
Collaborator Author

Still need to write documentation on this though...

@chazzmoney chazzmoney changed the title Either add modifiers or write documentation on modifications via JS property files Write documentation on modifications via JS property files Aug 30, 2019
@dbanksdesign dbanksdesign mentioned this issue May 5, 2021
Merged
dbanksdesign added a commit that referenced this issue May 12, 2021
@dbanksdesign
chore(docs): v3 docs update (#617)
048bbab 
Fixes #571 #159 #605
* Renamed "style properties" to "design tokens"
    * Adding tokens and allTokens to the core internal data structure to be consistent with this change. This is purely additional, properties and allProperties still exist and this should not break existing code. Moving forward examples should use tokens rather than properties.
    * properties.md -> tokens.md
    * Adding more content in this doc page about:
        * All potential attributes #605
        * Default attributes Style Dictionary adds
        * More info on what categories the CTI currently supports #571
        * Information on file formats for token files, including JS modules #159, and custom parsers for token files
* Updated broken links (linking to "master" branch instead of "main")
* Updated the examples page with all new examples
* Added a page on custom parsers
* Added information about transitive transforms
* Removed "docs/build_process.md" in favor of "docs/architecture.md" because the content was mostly the same.
* Cleaned up configuration content
    * Updated language around config file formats and how to define the configuration
    * Added information about configuration attributes and separated it out into sections: top-level config attributes including customization, platform attributes, and file attributes, for readability
* Cleaning up some spacing and headers in markdown files
@dbanksdesign
Copy link
Member

dbanksdesign commented May 12, 2021 •
edited

This is fixed in 3.0!

SD 3.0 automation moved this from To do to Done May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbanksdesign dbanksdesign

Labels
chore documentation
Projects
No open projects
SD 3.0
  
Done
Milestone
3.0
Development

No branches or pull requests
2 participants
@dbanksdesign @chazzmoney