Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The native parseFloat() only has one argument #416

Closed
tlehtimaki opened this issue Apr 8, 2020 · 2 comments
Closed

The native parseFloat() only has one argument #416

tlehtimaki opened this issue Apr 8, 2020 · 2 comments

Comments

@tlehtimaki
Copy link
Contributor

There is minor bug in ./lib/common/transforms.js where parseFloat is given two arguments. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseFloat

I assume it has been accidentally been confused with parseInt() which has second optional argument for radix.
@tlehtimaki tlehtimaki mentioned this issue Apr 8, 2020
Merged
@dbanksdesign
Copy link
Member

🤦‍♂ my bad

chazzmoney pushed a commit that referenced this issue Apr 17, 2020
@tlehtimaki
fix: parseFloat() has only one argument (#417)
16c3040 
fixes issue #416
@chazzmoney
Copy link
Collaborator

chazzmoney commented Apr 17, 2020 •
edited
Loading

Fixed in merge of #417

Thank you!

dbanksdesign pushed a commit that referenced this issue Oct 5, 2020
@tlehtimaki @dbanksdesign
fix: parseFloat() has only one argument (#417)
5749b2f 
fixes issue #416
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dbanksdesign @chazzmoney @tlehtimaki