fix: update style-dictionary clean config path
#454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`style-dictionary build` and `style-dictionary clean` should use the same config path defaults
kyh
changed the title
style-dictionary clean config path
|
This looks like a solid bugfix to me - @dbanksdesign is there a reason that the clean would want to use a different method to get configs? |
kyh
changed the title
style-dictionary clean config pathstyle-dictionary clean config path
dbanksdesign
pushed a commit
that referenced
this pull request
Oct 8, 2020
`style-dictionary build` and `style-dictionary clean` were not using the same config path defaults. This fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
style-dictionary buildandstyle-dictionary cleanshould use the same default config pathsDescription of changes:
Ran into an issue where running
style-dictionary buildworked butstyle-dictionary cleanthrew an error because I was using config.js instead of config.jsonBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.