Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formats): change scss comments to short version #306

Merged
merged 2 commits into from
Jul 17, 2019
Merged

Conversation

dbanksdesign
Copy link
Member

Issue #, if available: #305

Description of changes: Change scss variables format to use shorthand comments // rather than block comments so they don't pollute the compiled CSS.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@didoo
Copy link
Contributor

didoo commented Jul 10, 2019

LGTM!

@chazzmoney
Copy link
Collaborator

We should make the same change to the less format as per @nategreen comment in #305

Otherwise, LGTM!

@chazzmoney
Copy link
Collaborator

chazzmoney commented Jul 17, 2019

👍 :shipit:

@chazzmoney chazzmoney merged commit 4f13f57 into master Jul 17, 2019
@dbanksdesign dbanksdesign deleted the fix-305 branch August 28, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants