feat(parser): adding custom parser support #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chazzmoney
approved these changes
Jun 5, 2020
__tests__/extend.test.js
Outdated
| @@ -171,7 +171,7 @@ describe('extend', () => { | |||
| var StyleDictionaryExtended = StyleDictionary.extend(__dirname + '/__configs/test.json5'); | |||
| expect(StyleDictionaryExtended).toHaveProperty('platforms.web'); | |||
| }); | |||
|
|
|||
__tests__/utils/combineJSON.test.js
Outdated
| @@ -13,6 +13,7 @@ | |||
|
|
|||
| var combineJSON = require('../../lib/utils/combineJSON'); | |||
| var path = require('path'); | |||
| const yaml = require('yaml'); | |||
There was a problem hiding this comment.
For code consistency, should we leave this var for now and then move them all to const when we do the ES6 changeover?
| @@ -39,13 +39,15 @@ var StyleDictionary = { | |||
| format: require('./lib/common/formats'), | |||
| action: require('./lib/common/actions'), | |||
| filter: {}, // we need to initialise the object, since we don't have built-in filters | |||
| parsers: [], // ditto ^ | |||
lib/extend.js
Outdated
| @@ -103,7 +103,7 @@ function extend(opts) { | |||
| if (!_.isArray(options.include)) | |||
| throw new Error('include must be an array'); | |||
|
|
|||
| to_ret.properties = combineJSON(options.include, true); | |||
| to_ret.properties = combineJSON(options.include, true, null, to_ret.parsers); | |||
There was a problem hiding this comment.
this might conflict with one of the PRs in progress... not sure which one but I feel like I remember this...
There was a problem hiding this comment.
Right you are, #356 we should probably merge that one in first and then I'll go fix this afterwards
dbanksdesign
force-pushed
the
parser-support
branch
from
7340872
to
f71cd81
Compare
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #85
Description of changes: Adding custom parser support. This allows you to write token files in any language you like as long as you can parse the file. For example you can write your tokens in YAML and use the
yaml.parse. This adds.registerParseras well as documentation, examples, and tests. A custom parser has a file pattern regex to match certain types of files, and a parse function that takes the file contents as a string and returns a plain Javascript object.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.