feat(formats): add support for Microsoft's JSONC format #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrevorBurnham
commented
Nov 6, 2021
| @@ -79,6 +79,7 @@ | |||
| ], | |||
| "transform": { | |||
| "^.+\\.json5$": "json5-jest", | |||
| "^.+\\.jsonc$": "json5-jest", | |||
There was a problem hiding this comment.
Here I've taken advantage of the fact that JSON5 is a superset of JSONC, so the same transform satisfies Jest. I initially writing my own JSONC transform, based on the JSON5 one—it's basically a one-liner—but for some reason I couldn't get Jest to actually run it. 🤷♂️
dbanksdesign
approved these changes
Nov 9, 2021
| @@ -228,6 +228,11 @@ describe('extend', () => { | |||
| expect(StyleDictionaryExtended).toHaveProperty('platforms.web'); | |||
| }); | |||
|
|
|||
| it('should accept a string as a path to a JSONC file', function() { | |||
| @@ -12,6 +12,7 @@ | |||
| */ | |||
|
|
|||
| require('json5/lib/register'); | |||
| require.extensions[".jsonc"] = require("./utils/jsonc").register; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #698
Description of changes: This PR adds full support for JSONC (specifically the implementation used by VS Code for its configuration files) as a configuration and token format.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. ✅