Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): Correct type of Core.format #780

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Conversation

jakobe
Copy link
Contributor

@jakobe jakobe commented Feb 16, 2022

Issue #, if available: closes #779

Description of changes:
Core.format now has correct type (Formatter instead of Format).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@dbanksdesign dbanksdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@jakobe
Copy link
Contributor Author

jakobe commented Feb 21, 2022

LGTM! :shipit:

Great :)

So - who can :shipit: ?

@dbanksdesign dbanksdesign merged commit 9868b7e into amzn:main Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type definition of Core.format is not correct
2 participants