fix(transforms): transitive transforms now work without .value in refs #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chazzmoney
requested changes
Apr 7, 2022
__tests__/exportPlatform.test.js
Outdated
Comment on lines
91
to
93
| one: { value: 'foo' }, | ||
| two: { value: '{one}' }, | ||
| three: { value: '{two}' } |
There was a problem hiding this comment.
Can we add a couple tests that check different combinations of references with and without .value?
| value: "{color.font.secondary.value}", | ||
| value: "{color.font.secondary}", |
There was a problem hiding this comment.
If we believe not having ".value" is the preferred method that we would like people to follow, this is great!
If not, it could be worthwhile to leave one of these with the .value appended so people know they can use it either way. Though, maybe that would be confusing and it is better to have a suggested method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#794
Description of changes:
Updated
resolveObjectfunction to do the ignorePaths check based on if the reference has a value or not. This allows transitive transforms to work on references without.valueBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.