Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added packageName as optional property on interface File #829

Merged
merged 1 commit into from
Dec 16, 2022
Merged

fix: added packageName as optional property on interface File #829

merged 1 commit into from
Dec 16, 2022

Conversation

aborgan
Copy link
Contributor

@aborgan aborgan commented Jun 14, 2022

Issue #, if available: N/A

Description of changes:

The packageName property is not present on the File interface, but is listed in the docs and is used in testing here.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@dbanksdesign dbanksdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexiscordova
Copy link

@dbanksdesign can we get this merged? I think only repo admins have write access. Thanks!

@dbanksdesign dbanksdesign merged commit 0996cc4 into amzn:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants