Add missing className file format documentation for ios-swift classes #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanksdesign
requested changes
Mar 16, 2023
There was a problem hiding this comment.
Thank you for catching this! That props table is generated from a JSDoc comment, here: https://github.com/amzn/style-dictionary/blob/main/lib/common/formats.js#L915
And then run npm run generate-docs
Just to make sure this change doesn't get wiped out.
germain-gg
force-pushed
the
add-missing-format-property
branch
from
33add50
to
a192833
Compare
|
Thank you for the review @dbanksdesign |
dbanksdesign
approved these changes
Mar 23, 2023
dbanksdesign
pushed a commit
that referenced
this pull request
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Adding the missing file property
className.This template (see https://github.com/amzn/style-dictionary/blob/main/lib/common/templates/ios-swift/any.swift.template) confirms that this property can be used, but is undocumented,
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.