Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static files compressed with brotli (br_static=true) will fail to be sent if uncompressed file doesn't exist #1302

Open
theoreticalphysicsftw opened this issue Jun 29, 2022 · 0 comments

Comments

@theoreticalphysicsftw
Copy link

The checks whether or not the *.br compressed files exist are done in StaticFileRouter::sendStaticFileResponse, however if the original uncompressed file doesn't exist in the static file location then the request would be rejected much before that inside StaticFileRouter::route which checks for the existence of the original uncompressed file without the .br extension even tho the *.br file exists there. Doesn't it make more sense for those checks to be added inside the route function as well so that compressed files can be sent by request even if the uncompressed ones don't exist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant