Skip to content

Commit

Permalink
linebreak-style makes it impossible for Windows users to contribute
Browse files Browse the repository at this point in the history
Any project that currently uses eslint-config-airbnb checked out on Windows results in thousands of linter errors since the line endings will be CRLF, making it impossible to contribute to these projects as a Windows user without nerfing the linter entirely.

A better way to enforce this is not via a linter, but via a .gitattributes file (https://help.github.com/articles/dealing-with-line-endings). When you do this, Git will ensure the repo internally is LF, but on Win32 will check out files as CRLF (this is a builtin case of a clean/smudge filter)

Refs vercel/hyper#1230, xojs/eslint-config-xo#35
  • Loading branch information
anaisbetts committed Dec 28, 2016
1 parent c6b7c9e commit b7e4347
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions packages/eslint-config-airbnb-base/rules/style.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,6 @@ module.exports = {
applyDefaultPatterns: true,
}],

// disallow mixed 'LF' and 'CRLF' as linebreaks
// http://eslint.org/docs/rules/linebreak-style
'linebreak-style': ['error', 'unix'],

// enforces empty lines around comments
'lines-around-comment': 'off',

Expand Down

0 comments on commit b7e4347

Please sign in to comment.