Ensure line endings are correct on Windows #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows Windows users to check out the repo and send in PRs without messing up the line endings, see https://help.github.com/articles/dealing-with-line-endings for more
|
Can we get this merged? Without this it's hard for any Windows user to contribute because every file is marked as changed because of line endings. |
|
This is actually even worse - because of the "linebreak-style" lint, I can't even push a branch because I'll get thousands of linter errors |
|
Yep, I'd been planning to submit this as well. Check out with no changes fails lint on Windows. |
anaisbetts
added a commit
to anaisbetts/javascript
that referenced
this pull request
Dec 28, 2016
Any project that currently uses eslint-config-airbnb checked out on Windows results in thousands of linter errors since the line endings will be CRLF, making it impossible to contribute to these projects as a Windows user without nerfing the linter entirely. A better way to enforce this is not via a linter, but via a .gitattributes file (https://help.github.com/articles/dealing-with-line-endings). When you do this, Git will ensure the repo internally is LF, but on Win32 will check out files as CRLF (this is a builtin case of a clean/smudge filter) Refs vercel/hyper#1230, xojs/eslint-config-xo#35
This was referenced Dec 28, 2016
|
Thank you and sorry for the delay, @paulcbetts! When I was porting Hyper to Windows, I always used |
|
@matheuss I'm still working on the linter, we probably will have to explicitly disable this. eslint/eslint#7823 is the current shitshow |
tylerong
pushed a commit
to tylerong/hyper
that referenced
this pull request
Jul 3, 2017
This allows Windows users to check out the repo and send in PRs without messing up the line endings, see https://help.github.com/articles/dealing-with-line-endings for more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Windows users to check out the repo and send in PRs without messing up the line endings, see https://help.github.com/articles/dealing-with-line-endings for more