docs: added comments

analog-nico · Feb 21, 2019 · ebbf9fe · ebbf9fe
1 parent c3cff4b
commit ebbf9fe
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/task/TaskDispatchTracker.js b/lib/task/TaskDispatchTracker.js
@@ -37,6 +37,8 @@ class TaskDispatchTracker {
 
     trackTaskStopped(name) {
 
+        // Must unregister task synchronously in this function to avoid race conditions
+
         this._concurrentTasks -= 1
 
         this._taskMap.get(name).concurrentTasks -= 1

diff --git a/lib/task/TaskDispatcher.js b/lib/task/TaskDispatcher.js
@@ -225,7 +225,7 @@ class TaskDispatcher {
                 let wasAtMaxCapacity = this._taskDispatchTracker.reachedMaxCapacity()
                 let wasAtMaxCapacityForTask = this._taskDispatchTracker.reachedMaxCapacityForTask(task.name)
 
-                this._taskDispatchTracker.trackTaskStopped(task.name)
+                this._taskDispatchTracker.trackTaskStopped(task.name) // Must be called synchronously before _pollForTask to avoid race conditions
 
                 let isNowAtMaxCapacity = this._taskDispatchTracker.reachedMaxCapacity()
                 let isNowAtMaxCapacityForTask = this._taskDispatchTracker.reachedMaxCapacityForTask(task.name)