-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tap count mismatch #28
Comments
…icesinc#28. Signed-off-by: Alexander Vickberg <wickbergster@gmail.com>
This breaks exporting to file. Everything in this comment has been generated with latest master as of today (924f0cd) and MATLAB 9.11.0.1837725 (R2021b) Update 2. Here is an example where according to me none of the files are correct: Case 1, design Rx filter first and Tx second, issue here is that Rx number of taps is set to 128 but actual number is 112. Resulting output:
Case 2, design Tx filter first and Rx second, issue here is that Tx number of taps is set to 112 but actual number is 128. Since it has 8 leading and ending zeros it could however be outputted as a filter of length 112. (I asked about this in #43). Result:
|
When creating filter files (.ftr) the saved file will only output the number of taps of the present chain selected (TX or RX). For example, if the RX channel is selected and the TX is already designed, and TX has 96 taps and RX has 80 taps, 80 taps will be written to the .ftr file.
The text was updated successfully, but these errors were encountered: