adrv9002 plugin fix for disabled channels #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunojsa
requested changes
Jan 30, 2024
andrei47w
force-pushed
the
adrv9002-fix
branch
from
ebe31a1
to
1345c5e
Compare
nunojsa
reviewed
Feb 2, 2024
andrei47w
force-pushed
the
adrv9002-fix
branch
from
1345c5e
to
2667f0b
Compare
nunojsa
previously approved these changes
Feb 8, 2024
nunojsa
previously approved these changes
Feb 15, 2024
nunojsa
dismissed
their stale review
I mistakenly approved it... With the above changes, I'll approve it
…hannel status - adrv9002_channel_is_enabled(struct adrv9002_common *chan) will return true or false Signed-off-by: Andrei Popa <andrei.popa@analog.com>
- used adrv9002_channel_is_enabled() helper function - some attributes cannot be read if channel is disabled, so they are set to 0 - improve warning messages Signed-off-by: Andrei Popa <andrei.popa@analog.com>
- split RX and TX for loop Signed-off-by: Andrei Popa <andrei.popa@analog.com>
… is not enabled Signed-off-by: Andrei Popa <andrei.popa@analog.com>
andrei47w
force-pushed
the
adrv9002-fix
branch
from
37a1846
to
c0391f2
Compare
nunojsa
approved these changes
Feb 16, 2024
… and removed for() loops - removed the for() loop by implicit memcpy() in lte_lvs_3072_MHz_10() to match lte_defaults() definition style Signed-off-by: Andrei Popa <andrei.popa@analog.com>
- replaced it with ADRV9002_NUM_CHANNELS which has the same value - remove implied size for lists in profile_gen_update_channels() Signed-off-by: Andrei Popa <andrei.popa@analog.com>
andrei47w
force-pushed
the
adrv9002-fix
branch
from
c0391f2
to
e149850
Compare
nunojsa
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The profile gen was failing to create a configuration since some attributes cannot be read if the channel is disabled