Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: add uninstall target #694

Closed
willcode opened this issue Jun 2, 2021 · 5 comments
Closed

cmake: add uninstall target #694

willcode opened this issue Jun 2, 2021 · 5 comments
Assignees
@pcercuei
Labels
enhancement

Comments

@willcode
Copy link

willcode commented Jun 2, 2021

An "uninstall" target is useful both for development and for source-based package management (PyBOMBS in our case).

While cmake does not have a convenient uninstall, it is typically implemented using code like:
https://gist.github.com/royvandam/3033428
@rgetz
Copy link
Contributor

rgetz commented Feb 22, 2022

Thanks - we will have a look - and try to add

@rgetz
Copy link
Contributor

rgetz commented Feb 8, 2023

There should be file "install_manifest.txt" after executing make install. Either of the following commands should work:

cat install_manifest.txt | sudo xargs rm

or

xargs sudo rm < install_manifest.txt

Does that solve your issue?

@willcode
Copy link
Author

willcode commented Feb 9, 2023

Hi @rgetz, sure that's fine for a manual uninstall. I put this in originally because PyBOMBS runs make uninstall explicitly. This issue has been up for quite a while, and I don't hear any complaints. Not that surpising since the PyBOMBS recipe calls for an ancient tag. Feel free to close it if adding make uninstall is not a priority.

The recipe has specified v0.21 for a while now. I'd guess that people using PyBOMBS and PLUTO are installing via a package manager.

rgetz added a commit to rgetz/libiio that referenced this issue May 6, 2023
@rgetz
add uninstall target
7337466 
Per the request analogdevicesinc#694, this adds an "uninstall" target, which is (a) good
form, and (b) requested by Jeff Long, and will make PyBOMBs work more
natively.

Signed-off-by: Robin Getz <rgetz@mathworks.com>
@rgetz rgetz mentioned this issue May 6, 2023
Merged
@rgetz
Copy link
Contributor

rgetz commented May 6, 2023

When #961 gets merged - this can be closed.

rgetz added a commit to rgetz/libiio that referenced this issue May 11, 2023
@rgetz
add uninstall target
2e1f67e 
Per the request analogdevicesinc#694, this adds an "uninstall" target, which is (a) good
form, and (b) requested by Jeff Long, and will make PyBOMBs work more
natively.

Signed-off-by: Robin Getz <rgetz@mathworks.com>
pcercuei pushed a commit that referenced this issue May 11, 2023
@rgetz @pcercuei
add uninstall target
0a5eaa2 
Per the request #694, this adds an "uninstall" target, which is (a) good
form, and (b) requested by Jeff Long, and will make PyBOMBs work more
natively.

Signed-off-by: Robin Getz <rgetz@mathworks.com>
@rgetz
Copy link
Contributor

rgetz commented Oct 16, 2023

this can be closed - it was included in 0.25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcercuei pcercuei

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pcercuei @rgetz @willcode