Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sorting: Use old sorting algorithm for channels #269

Merged
merged 1 commit into from
May 3, 2019
Merged

sorting: Use old sorting algorithm for channels #269

merged 1 commit into from
May 3, 2019

Conversation

adisuciu
Copy link
Contributor

This algorithm should be backwards compatible

Signed-off-by: Adrian Suciu adrian.suciu@analog.com

@adisuciu
sorting: Use old sorting algorithm for channels
f331535 
This algorithm should be backwards compatible

Signed-off-by: Adrian Suciu <adrian.suciu@analog.com>
@pcercuei
Copy link
Contributor

I think it is OK as it is now, the apps should not rely on the sorting of the channels or attributes, but rather use iio_device_find_channel.

@mhennerich
Copy link
Contributor

No - it's still broken -
The issue is that remote via IIOD and local share a channel enable mask. If channel sorting on both ends is done differently things fail, since the bits set doesn’t correspond to the same channels.
If we want to maintain backwards compatibility I see no way around reverting the channel sorting completely.

@mhennerich
Copy link
Contributor

Hi @pcercuei,

Do you see a way of fixing this while maintaining backward compatibility?

@pcercuei
Copy link
Contributor

Ah, right. I don't think there's an easy way to fix this then. The revert would be the proper solution.

@mhennerich mhennerich self-requested a review April 30, 2019 06:22
@mhennerich mhennerich merged commit f1d00f1 into master May 3, 2019
@mhennerich mhennerich deleted the sort-old-reorder branch May 3, 2019 13:37
mhennerich added a commit that referenced this pull request May 3, 2019
@mhennerich
Bump to version v0.18
46e4dbc 
This fixes a channel sorting bug which has caused compatibility issues,
in case the local and remote libiio differed in version.
This will revert the channel sorting changes and thus restore backward
compatibility to v0.15 and before. Version 0.16 and 0.17 should not
be used.

Changelog:

f331535 sorting: Use old sorting algorithm for channels
826563e CI/travis/lib.sh: fix triggering multiple builds
cce2ee2 CI/travis/inside_docker.sh: handle lowercase `ci` dir
f06a730 CI/travis/jobs_running_cnt.py: count `created` states as well
ed5ddb2 build,.travis.yml: drop xcode 8 build
f24c618 CI/travis/lib.sh: make the build dir configurable
f79c01b CI/travis: disable debug tracing
b7c1584 CI/travis/lib.sh: rework artifact removal via SFTP
1e23f69 CI/travis/lib.sh: add echo_[red,green,blue] functions

Adrian Suciu (1):
      sorting: Use old sorting algorithm for channels

Alexandru Ardelean (8):
      CI/travis/lib.sh: add echo_[red,green,blue] functions
      CI/travis/lib.sh: rework artifact removal via SFTP
      CI/travis: disable debug tracing
      CI/travis/lib.sh: make the build dir configurable
      build,.travis.yml: drop xcode 8 build
      CI/travis/jobs_running_cnt.py: count `created` states as well
      CI/travis/inside_docker.sh: handle lowercase `ci` dir
      CI/travis/lib.sh: fix triggering multiple builds

Michael Hennerich (1):
      Merge pull request #269 from analogdevicesinc/sort-old-reorder

Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
dbogdan pushed a commit that referenced this pull request May 22, 2019
@mhennerich @dbogdan
Bump to version v0.18
7653690 
This fixes a channel sorting bug which has caused compatibility issues,
in case the local and remote libiio differed in version.
This will revert the channel sorting changes and thus restore backward
compatibility to v0.15 and before. Version 0.16 and 0.17 should not
be used.

Changelog:

f331535 sorting: Use old sorting algorithm for channels
826563e CI/travis/lib.sh: fix triggering multiple builds
cce2ee2 CI/travis/inside_docker.sh: handle lowercase `ci` dir
f06a730 CI/travis/jobs_running_cnt.py: count `created` states as well
ed5ddb2 build,.travis.yml: drop xcode 8 build
f24c618 CI/travis/lib.sh: make the build dir configurable
f79c01b CI/travis: disable debug tracing
b7c1584 CI/travis/lib.sh: rework artifact removal via SFTP
1e23f69 CI/travis/lib.sh: add echo_[red,green,blue] functions

Adrian Suciu (1):
      sorting: Use old sorting algorithm for channels

Alexandru Ardelean (8):
      CI/travis/lib.sh: add echo_[red,green,blue] functions
      CI/travis/lib.sh: rework artifact removal via SFTP
      CI/travis: disable debug tracing
      CI/travis/lib.sh: make the build dir configurable
      build,.travis.yml: drop xcode 8 build
      CI/travis/jobs_running_cnt.py: count `created` states as well
      CI/travis/inside_docker.sh: handle lowercase `ci` dir
      CI/travis/lib.sh: fix triggering multiple builds

Michael Hennerich (1):
      Merge pull request #269 from analogdevicesinc/sort-old-reorder

Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
commodo pushed a commit that referenced this pull request May 23, 2019
@mhennerich @commodo
Bump to version v0.18
d387c25 
This fixes a channel sorting bug which has caused compatibility issues,
in case the local and remote libiio differed in version.
This will revert the channel sorting changes and thus restore backward
compatibility to v0.15 and before. Version 0.16 and 0.17 should not
be used.

Changelog:

f331535 sorting: Use old sorting algorithm for channels
826563e CI/travis/lib.sh: fix triggering multiple builds
cce2ee2 CI/travis/inside_docker.sh: handle lowercase `ci` dir
f06a730 CI/travis/jobs_running_cnt.py: count `created` states as well
ed5ddb2 build,.travis.yml: drop xcode 8 build
f24c618 CI/travis/lib.sh: make the build dir configurable
f79c01b CI/travis: disable debug tracing
b7c1584 CI/travis/lib.sh: rework artifact removal via SFTP
1e23f69 CI/travis/lib.sh: add echo_[red,green,blue] functions

Adrian Suciu (1):
      sorting: Use old sorting algorithm for channels

Alexandru Ardelean (8):
      CI/travis/lib.sh: add echo_[red,green,blue] functions
      CI/travis/lib.sh: rework artifact removal via SFTP
      CI/travis: disable debug tracing
      CI/travis/lib.sh: make the build dir configurable
      build,.travis.yml: drop xcode 8 build
      CI/travis/jobs_running_cnt.py: count `created` states as well
      CI/travis/inside_docker.sh: handle lowercase `ci` dir
      CI/travis/lib.sh: fix triggering multiple builds

Michael Hennerich (1):
      Merge pull request #269 from analogdevicesinc/sort-old-reorder

Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhennerich mhennerich mhennerich approved these changes

@rgetz rgetz Awaiting requested review from rgetz

@pcercuei pcercuei Awaiting requested review from pcercuei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adisuciu @pcercuei @mhennerich