[media] adv7604: remove duplicate reset code of gpios #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefpopa
approved these changes
Feb 2, 2018
Seems this was left-over from a merge commit. Probably this commit 41d036b (Merge remote-tracking branch 'xilinx/master' into xcomm_zynq_4_9) Remove it, since it's a duplicate reset. The duplicate code is viewable in right above this patch/change. Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
commodo
force-pushed
the
adv7604_remove_duplicate_reset_code
branch
from
e615810
to
c65fd04
Compare
|
Changelog V1 => V2:
|
dbogdan
approved these changes
Feb 2, 2018
lclausen-adi
approved these changes
Feb 2, 2018
btogorean
pushed a commit
that referenced
this pull request
Aug 25, 2023
[ Upstream commit ea60a4a ] When the dev init failed, should cleanup the sysfs, otherwise, the module will never be loaded since can not create duplicate sysfs directory: sysfs: cannot create duplicate filename '/fs/orangefs' CPU: 1 PID: 6549 Comm: insmod Tainted: G W 6.0.0+ #44 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-1.fc33 04/01/2014 Call Trace: <TASK> dump_stack_lvl+0x34/0x44 sysfs_warn_dup.cold+0x17/0x24 sysfs_create_dir_ns+0x16d/0x180 kobject_add_internal+0x156/0x3a0 kobject_init_and_add+0xcf/0x120 orangefs_sysfs_init+0x7e/0x3a0 [orangefs] orangefs_init+0xfe/0x1000 [orangefs] do_one_initcall+0x87/0x2a0 do_init_module+0xdf/0x320 load_module+0x2f98/0x3330 __do_sys_finit_module+0x113/0x1b0 do_syscall_64+0x35/0x80 entry_SYSCALL_64_after_hwframe+0x46/0xb0 kobject_add_internal failed for orangefs with -EEXIST, don't try to register things with the same name in the same directory. Fixes: 2f83ace ("orangefs: put register_chrdev immediately before register_filesystem") Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com> Signed-off-by: Mike Marshall <hubcap@omnibond.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems this was left-over from a merge commit.
Probably this commit 41d036b (Merge remote-tracking branch
'xilinx/master' into xcomm_zynq_4_9)
Remove it, since it's a duplicate reset.
The duplicate code is viewable in right above this patch/change.
Signed-off-by: Alexandru Ardelean alexandru.ardelean@analog.com