arch: microblaze,nios2: unify dtb build test into one build and extend to microblaze & nios2 #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to run multiple docker instances for different architectures in order to build DTs from different archs. We can group everything in a single build and run it. This saves time, and allows us to extend the DT check to Microblaze & NIOS2. Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Building the device-trees requires too much stuff (i.e. arch-specific compilers) to build device-trees. This isn't really required. Upstream kernel has some patches to reduce this dependency on the arch-specific compiler. So, for the DTB build test we patch the kernel build and take advantage of those changes, and we also avoid the risk of breaking other stuff. Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
The #include directive is a bit more flexible/permissive when including a mix of DTs and C header files with dt-binding macros. We did the same for ARM [Zynq] DTs. Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Otherwise there are DTC parser errors in * kcu105_adrv9371x.dts * vcu118_quad_ad9081.dts Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
….dtsi The only reason to do this, is to please the auto-check for device-tree building. DTS files are typically expected to be standalone, while dtsi files are expected to be includes. Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
The dtb building logic requires a Makefile in arch/$arch/boot/dts/Makefile, even if it's just empty. nios2 does not have one, so add one. Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
commodo
force-pushed
the
dts-single-build1
branch
from
f131105
to
ccefd11
Compare
nunojsa
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some microblaze DTs were broken in master as well (i.e. kcu105_adrv9371x.dts & vcu118_quad_ad9081.dts).
This build change should help us catch things really early on regarding DTs in microblaze & nios2.
We don't build those too often, but we should at least make sure DTs build, since the build-effort (for the CI server) is not too big.
Signed-off-by: Alexandru Ardelean alexandru.ardelean@analog.com