Skip to content

Commit

Permalink
pg_channel_manager: remove unused decc variable assignment
Browse files Browse the repository at this point in the history
This has been put into it's own commit, because it returns a decoder
object, but at the same time, it's not clear if there is anything wrong
with removing it (i.e. whether the decoder() method does anything behind
the scenes that would break anything).

Generally, it looks like removing it is ok, but it's in a separate commit
to draw more attention to it.

Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
  • Loading branch information
commodo committed Apr 16, 2019
1 parent 2dfa240 commit 6131cd7
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/pg_channel_manager.cpp
Expand Up @@ -935,8 +935,6 @@ void PatternGeneratorChannelGroupUI::setupUARTDecoder()

// Add the decoder rows

auto decc = uartdecoder->decoder();

auto decoderAnnotations = 3;

for (auto i=0; i<decoderAnnotations; i++) {
Expand Down Expand Up @@ -1006,7 +1004,6 @@ void PatternGeneratorChannelGroupUI::setupSPIDecoder()
spidecoder->set_option("cpha", g_variant_new_int64(!spipattern->getCPHA()));
//spidecoder->set_option("wordsize", g_variant_new_int64(spipattern->getBytesPerFrame()*8));

auto decc = spidecoder->decoder();
auto decoderAnnotations = 3;

for (auto i=0; i<decoderAnnotations; i++) {
Expand Down

0 comments on commit 6131cd7

Please sign in to comment.