fix(vite-plugin-angular): update plugin to ignore tsx files #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himyjan
changed the title
himyjan
changed the title
|
Thanks @himyjan. Let's keep this PR focused on fixing the bug. The package.json and other updates should be in a separate PR. |
brandonroberts
requested changes
Oct 11, 2022
| @@ -122,7 +122,7 @@ export function angular(options?: PluginOptions): Plugin[] { | |||
| await buildAndAnalyze(); | |||
| }, | |||
| async handleHotUpdate(ctx) { | |||
| if (/\.[cm]?tsx?$/.test(ctx.file)) { | |||
| if (/\.[cm]?ts?$/.test(ctx.file)) { | |||
There was a problem hiding this comment.
Remove the question mark also
Suggested change
| if (/\.[cm]?ts?$/.test(ctx.file)) { | |
| if (/\.[cm]?ts$/.test(ctx.file)) { |
| @@ -173,7 +173,7 @@ export function angular(options?: PluginOptions): Plugin[] { | |||
| return; | |||
| } | |||
|
|
|||
| if (/\.[cm]?tsx?$/.test(id)) { | |||
| if (/\.[cm]?ts?$/.test(id)) { | |||
There was a problem hiding this comment.
Same as above
Suggested change
| if (/\.[cm]?ts?$/.test(id)) { | |
| if (/\.[cm]?ts$/.test(id)) { |
change line 125 176 from tsx to ts, set plugin not try to compile tsx file. #100 (comment) Update angular-vite-plugin.ts
brandonroberts
changed the title
brandonroberts
approved these changes
Oct 11, 2022
|
Thanks @himyjan! @allcontributors add @himyjan for code |
|
I've put up a pull request to add @himyjan! 🎉 |
Villanuevand
pushed a commit
to Villanuevand/analog
that referenced
this pull request
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change line 125 176 from tsx to ts, set plugin not try to compile tsx file. #100 (comment)
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Issue Number: #100
What is the new behavior?
1.fix #100 only comple .ts file
Does this PR introduce a breaking change?
Other information