Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only assign ngDevMode during build #373

Merged
merged 1 commit into from
May 5, 2023
Merged

Conversation

brandonroberts
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Closes #345

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@netlify
Copy link

netlify bot commented May 5, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit ca597a0
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/64545493197e030008d7d88e
😎 Deploy Preview https://deploy-preview-373--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 5, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit ca597a0
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/64545493702fad000843e344
😎 Deploy Preview https://deploy-preview-373--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 5, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit ca597a0
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/64545493a1138e0008e019dc
😎 Deploy Preview https://deploy-preview-373--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@goetzrobin goetzrobin merged commit b89a47a into main May 5, 2023
15 checks passed
@goetzrobin goetzrobin deleted the fix-ngdevmode-v16 branch May 5, 2023 06:41
@goetzrobin
Copy link
Member

🚀

Villanuevand pushed a commit to Villanuevand/analog that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: client hydration stats not correctly displayed in Analog project
2 participants