fix(trpc): remove hard coded superjson transformer in favor of trpc client options & add e2e tests #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Not sure why the e2e tests fail on the CI... |
…options & add e2e tests instead of hardcoding the superjson transformer into our trpc client I removed it and in favor of allowing the default trpc clients options object to be passed in and forwarded to said trpc client. this allows users to pass in whatever transformers they want and also additional links. I also added e2e tests for the trpc-app that ensures a basic insert, read, and delete functionality works!
goetzrobin
force-pushed
the
remove-superjson-transform
branch
from
076de28
to
f84ca74
Compare
gergobergo
reviewed
May 8, 2023
gergobergo
reviewed
May 8, 2023
|
I think e2e tests fail due to nitro showing a reloading server page and the FE already sending the request expecting a JSON response for the tRPC client |
goetzrobin
requested review from
gergobergo and
brandonroberts
and removed request for
gergobergo
brandonroberts
changed the title
brandonroberts
approved these changes
May 8, 2023
Villanuevand
pushed a commit
to Villanuevand/analog
that referenced
this pull request
Sep 12, 2023
…lient options & add e2e tests (analogjs#378)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Currently the tRPC client had a hardcoded transformer with superjson.
It would be better to leave the transformation up to the user.
Issue Number: N/A
What is the new behavior?
Instead of hardcoding the superjson transformer into our trpc client I removed it and in favor of allowing the default trpc clients options object to be passed in and forwarded to said trpc client. this allows users to pass in whatever transformers they want and also additional links. I also added e2e tests for the trpc-app that ensures a basic insert, read, and delete functionality works!
We now accept the same options as the tRPC client.
Does this PR introduce a breaking change?
Other information