Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An error message popped up when using #44

Closed
LooDaHu opened this issue Jan 28, 2020 · 3 comments · Fixed by #47
Closed

An error message popped up when using #44

LooDaHu opened this issue Jan 28, 2020 · 3 comments · Fixed by #47

Comments

@LooDaHu
Copy link

LooDaHu commented Jan 28, 2020

Hi, @analyticalmonk . I got an error message when I try to reproduce examples at the README page. I forked your stringr repo and committed twice with some small changes in test-join.r. Then I tried plot_metrics and I got an error message, Here is the console log:

> getwd()
[1] "C:/Users/65112/Documents/stringr"
> plot_metrics(test_path = "tests/testthat/test-join.r", metric = "time", num_commits = 2, save_data = FALSE, save_plots = FALSE)
Error in base::substr(commit_val@summary, start = 1, stop = 15) : 
  trying to get slot "summary" from an object (class "git_commit") that is not an S4 object 

There is no error message when num_commits = 0 and no plot comes out.
Could you help me with this problem? Thank you in advance.

@analyticalmonk
Copy link
Owner

Hi @LooDaHu,
It seems that this could be because of a change in one of the dependency packages. I'll have a look at get back to you in a day or two.

@analyticalmonk
Copy link
Owner

Hi @LooDaHu,
It took me some time before I got the chance to look at this. This error occurred due to the breaking changes that had happened to git2r sometime back due to them switching to S3 objects from S4. The latest git2r version that Rperform will work with is 0.21.0.

As a temporary fix, I've modified the DESCRIPTION file. I've also opened an issue here: #45

Please let me know if this helps.

@LooDaHu
Copy link
Author

LooDaHu commented Feb 12, 2020

Hi @analyticalmonk,
Thanks for the info, this is helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants