Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency issues #2

Closed
wants to merge 13 commits into from
Closed

Conversation

EngineerDanny
Copy link
Owner

@EngineerDanny EngineerDanny commented Jun 21, 2022

The animint package in the root DESCRIPTION file has been discontinued.
The Github CI test showed that it is not possible to install it because it could not recognize the package.
Fast forward, there is an updated version called the animint2 which comes with improved features and better syntax.

@EngineerDanny
Copy link
Owner Author

EngineerDanny commented Jun 21, 2022

This PR changes the DESCRIPTION file by updating the animint2 package.
I have updated, checked and tested all the functions that depend on the animint2 package.

@EngineerDanny
Copy link
Owner Author

EngineerDanny commented Jun 21, 2022

Github CI Test Before the PR :

Screenshot 2022-06-21 at 2 39 41 PM

Github CI Test After initial PR :

Screenshot 2022-06-21 at 2 42 24 PM

git2r package is the only package left to be updated.

@EngineerDanny EngineerDanny self-assigned this Jun 21, 2022
@EngineerDanny
Copy link
Owner Author

git2r update PR #3 has been merged into this branch since they all address dependency conflicts.

@EngineerDanny
Copy link
Owner Author

EngineerDanny commented Jun 22, 2022

This PR also focuses on updating the git2r package to support the latest features and improvements.
More specifically, git2r (>= 0.30.1)
However, updating the package came with a minor hurdle.
The package has transitioned from supporting S4 objects to S3 objects.
Hence, it has made some of the functions used with git2r (<= 0.21.0) obsolete.
Therefore, I have updated and tested all the git2r functions that we use to support S3 objects.

This PR fixes issues #44 and #45

@EngineerDanny EngineerDanny changed the title Fix dependency conflicts Fix dependency issues Jun 22, 2022
@EngineerDanny
Copy link
Owner Author

EngineerDanny commented Jun 22, 2022

Explicitly writing scripts to install dependencies is not widely accepted in the R community since it makes the DESCRIPTION file redundant.
Therefore, r-lib/actions/setup-r-dependencies is adopted to automatically install packages declared in DESCRIPTION.

The Github CI test is now successful ✅.

@tdhock
Copy link
Collaborator

tdhock commented Jun 23, 2022

binary files like .github/actions/.DS_Store should not be added to the github repo. please remove them from the PR and add .DS_Store to the .gitignore file.

.github/actions/test-info/entrypoint.sh Show resolved Hide resolved
R/plot_metrics.R Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants