Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and fix related issues, create Github Workflow for Rperform #47

Merged
merged 31 commits into from Jun 27, 2022

Conversation

EngineerDanny
Copy link
Collaborator

This PR fixes most of the issues raised.

  1. Indentation inconsistency in the R files have been fixed by using R studio's built-in indentation. (1)
  2. Various binary files and directories have been added to the .gitignore file. (2)
  3. animint package has been updated to animint2 which comes with improved features and better syntax.
  4. git2r package has also been updated to support the latest features and improvements git2r (>= 0.30.1)
  5. Named reference approach has been adopted to reference list members by names instead of numeric indexes. (3)
  6. A Github CI Worflow has been created for setting up Rperform and running R CMD Check by using r-lib/actions

R CMD Check Runs successfully ✅

This PR closes #44 and fixes #45

Copy link
Owner

@analyticalmonk analyticalmonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.

We should also update the README to incorporate your findings regarding testing the stringr package with Rperform. We can do that in a separate PR.

@EngineerDanny
Copy link
Collaborator Author

EngineerDanny commented Jun 27, 2022 via email

@EngineerDanny EngineerDanny merged commit 328e269 into analyticalmonk:master Jun 27, 2022
@analyticalmonk
Copy link
Owner

Amazing work @EngineerDanny! 🎉
cc: @tdhock

@EngineerDanny
Copy link
Collaborator Author

EngineerDanny commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support git2r's switch from S4 to S3 objects An error message popped up when using
2 participants