New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and fix related issues, create Github Workflow for Rperform #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update git2r package
…rDanny/Rperform into fix-dependency-conflicts
Rperform R CMD Check
analyticalmonk
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good.
We should also update the README to incorporate your findings regarding testing the stringr
package with Rperform. We can do that in a separate PR.
Sure.
I will update that and submit another PR.
|
Amazing work @EngineerDanny! 🎉 |
Great Akash
…On Mon, Jun 27, 2022 at 5:41 PM Akash Tandon ***@***.***> wrote:
***@***.**** approved this pull request.
The changes look good.
We should also update the README to incorporate your findings regarding
testing the stringr package with Rperform. We can do that in a separate
PR.
—
Reply to this email directly, view it on GitHub
<#47 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALJZRXO57FYLN5K4LPF4QK3VRHRTFANCNFSM5ZZXRFZQ>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes most of the issues raised.
git2r (>= 0.30.1)
R CMD Check Runs successfully ✅
This PR closes #44 and fixes #45