Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gui): Added GUI support for destinationServiceAccount field #5

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

raghavi101
Copy link

@raghavi101 raghavi101 commented Feb 20, 2024

Jira : https://issues.redhat.com/browse/GITOPS-3505

  • Destination Service Account gets rendered and the UI takes in server, namespace and defaultServiceAccount values.
Screenshot 2024-02-19 at 6 21 16 PM

Signed-off-by: Raghavi Shirur <rshirur@redhat.com>
@raghavi101
Copy link
Author

Hi @keithchong I've rendered the above fields and it takes in the values as well as appends new values. Do take a look because I'm trying to see how i can get these to work :

  • validate each field for empty values
  • validate for duplicate values
  • send these values to the API which can then use these values to do the impersonation job.

@keithchong
Copy link

This was what I mentioned about. You have to create a global project and have one inherit from it to see this section. It's non-editable.

InheritedFromGlobal

@keithchong
Copy link

For the bullet points above, the Project's Update API needs to be changed. I think Anand is working/will be working on it. I believe the API will return an error for any invalid input values, so you probably don't have to do anything more.

@anandf anandf merged commit 535ea13 into anandf:sync_with_impersonate Mar 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants