Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test extensions #55

Open
wants to merge 14 commits into
base: meson
Choose a base branch
from
Open

Conversation

nbyavuz
Copy link
Collaborator

@nbyavuz nbyavuz commented Jun 21, 2022

I am not sure if that is correct way to test the extensions? Also, I tried a couple more extensions but it seems they don't support PG 15 yet. Do you have any other extension suggestions to add?

@nbyavuz nbyavuz requested a review from anarazel June 21, 2022 14:29
@nbyavuz nbyavuz force-pushed the meson-test-extensions branch 3 times, most recently from 561ee8f to 1f06345 Compare June 22, 2022 13:34
@nbyavuz
Copy link
Collaborator Author

nbyavuz commented Jun 22, 2022

I did some refactoring and added pgbouncer.

Some of the tests' of pgbouncer fail, they also fail on my local except test_password_server, which passes on my local.
(I didn't try pgbouncer with autoconf)

.cirrus.yml Outdated Show resolved Hide resolved
src/tools/ci/docker/linux_opensuse_tumbleweed_extension Outdated Show resolved Hide resolved
.cirrus.yml Outdated Show resolved Hide resolved
src/tools/ci/test_extensions Outdated Show resolved Hide resolved
@anarazel
Copy link
Owner

Some of the tests' of pgbouncer fail, they also fail on my local except test_password_server, which passes on my local.
(I didn't try pgbouncer with autoconf)

It'd be good to check if that works with autoconf. If it's reproducible there, worth opening a bug

I am not sure if that is correct way to test the extensions?

Looks good.

Also, I tried a couple more extensions but it seems they don't support PG 15 yet. Do you have any other extension suggestions to add?

A good source could be the list of extensions from the various cloud providers. E.g.
https://docs.microsoft.com/en-us/azure/postgresql/flexible-server/concepts-extensions#postgres-13-extensions
https://docs.aws.amazon.com/AmazonRDS/latest/PostgreSQLReleaseNotes/postgresql-extensions.html#postgresql-extensions-14x
Note that a lot of these are ones built into postgres (in contrib/), thus not worth testing.

Likely interesting:

  • oracfe
  • hll
  • pg_partman
  • hypopg
  • pg_qualstats
  • postgis (but that's likely too much work / too expensive)

@anarazel anarazel force-pushed the meson branch 3 times, most recently from e8cf3f5 to 1ee3073 Compare July 1, 2022 09:23
@anarazel anarazel force-pushed the meson branch 2 times, most recently from f1d9361 to 3203147 Compare July 15, 2022 05:08
@nbyavuz nbyavuz force-pushed the meson-test-extensions branch 2 times, most recently from 66a5254 to d32b323 Compare July 18, 2022 12:26
@anarazel anarazel force-pushed the meson branch 2 times, most recently from 5bde7a5 to dc1866e Compare July 18, 2022 19:56
@nbyavuz nbyavuz force-pushed the meson-test-extensions branch 7 times, most recently from 1fec615 to c247526 Compare July 25, 2022 10:38
@nbyavuz
Copy link
Collaborator Author

nbyavuz commented Jul 25, 2022

Some of the tests' of pgbouncer fail, they also fail on my local except test_password_server, which passes on my local.
(I didn't try pgbouncer with autoconf)

It'd be good to check if that works with autoconf. If it's reproducible there, worth opening a bug

I checked with autoconf and same errors appeared.


* oracfe

While building oracfe, it fails with:

others.c: In function ‘ora_get_major_version’:
others.c:511:42: error: ‘PACKAGE_STRING’ undeclared (first use in this function); did you mean ‘PACKAGE_VERSION’?
  511 |         PG_RETURN_TEXT_P(cstring_to_text(PACKAGE_STRING));

* hll

While building hll, it fails with:

src/hll.c:50:10: fatal error: utils/int8.h: No such file or directory
   50 | #include "utils/int8.h"

* pg_partman

Build step doesn't work, there is open issue for error: pgpartman/pg_partman#464 and I couldn't find a way to start tests of pg_partman.


* hypopg

Done.


* pg_qualstats

Done.


* postgis (but that's likely too much work / too expensive)

Almost done, only one test (in_gml) fails and it also fails on my local. It is interesting that I tested with autoconf and there were 2 tests (in_gml, long_xact) failed.


@anarazel
Copy link
Owner

anarazel commented Aug 1, 2022

While building hll, it fails with:

Does it work against an autoconf build?

Almost done, only one test (in_gml) fails and it also fails on my local. It is interesting that I tested with autoconf and there were 2 tests (in_gml, long_xact) failed.

Probably worth reporting to the postgis folks

@anarazel anarazel force-pushed the meson branch 2 times, most recently from 71483fb to 7c51b21 Compare March 21, 2023 01:23
@anarazel anarazel force-pushed the meson branch 3 times, most recently from 39b3034 to 454384a Compare April 11, 2023 22:13
@anarazel
Copy link
Owner

anarazel commented Jun 3, 2023

Could you rebase this?

Copy link
Owner

@anarazel anarazel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of the currently disabled extensions should now work?

@@ -0,0 +1,22 @@
2022-10-20 10:49:44.926 +03 [2932] LOG: starting PostgreSQL 16devel on x86_64, compiled by gcc-12.2.1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this actually need to me merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants