Remove unnecessary constraints #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unbreak building with arbitrary ncurses version using pkg-config
this creates warnings in Debian, as there are checks to see if we use proper hardening flags, for example. besides, we *almost* show all the tags in the compile rule, might as well not silence it
do not silence compiler flags
…est it buildds only choose the first build-dep, on purpose, for reproducibility, and ncurses6 is missing for now
the way this was working before, we would populate the ttyclock->lt field *after* fetching the ttyclock->tm structure, which means that would get the `localtime` of the *previous* iteration. this created a one second delay in the clock display that was, I believe, unintentional. this accounts for part of the 2s delay when compared to other clocks like vtclock or xclock. Closes: xorg62#40
set time structure at the right moment
previous Makefile changes didn't actually work for pkg-config. they were taken from the Debian package, which operated differently. furthermore, the ncurses5-config lines were incorrect: they were using both ncursesw and ncurses and would fail if --libdir was empty. instead, we use the more proper --cflags and --libs that all do the right thing. this should, arguably, only be done with pkg-config, but i didn't want to introduce an additional dependency. See: xorg62#38
another shot at fixing buildchain
CFLAGS and LDFLAGS may be passed in by an upstream build system. we want to make sure we absolutely add our dependency flags otherwise stuff like hardening flags will break the build Closes: xorg62#29
* Build-Depends: Drop versioned constraint on debhelper. Changes-By: deb-scrub-obsolete
|
This merge proposal will be closed, since all remaining changes have been |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary constraints.
This merge proposal was created automatically by the Janitor bot.
For more information, including instructions on how to disable
these merge proposals, see https://janitor.debian.net/scrub-obsolete.
You can follow up to this merge proposal as you normally would.
The bot will automatically update the merge proposal to resolve merge conflicts
or close the merge proposal when all changes are applied through other means
(e.g. cherry-picks). Updates may take several hours to propagate.
Build and test logs for this branch can be found at
https://janitor.debian.net/scrub-obsolete/pkg/tty-clock/771168dd-6a24-4b60-8089-79c2622bad32.
Debdiff
These changes affect the binary packages:
[The following lists of changes regard files as different if they have
different names, permissions or owners.]
Files in second set of .debs but not in first
Files in first set of .debs but not in second
No differences were encountered between the control files of package **tty-clock**
Control files of package tty-clock-dbgsym: lines which differ (wdiff format)
You can also view the diffoscope diff (unfiltered).