Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/llm vm add agents #17

Conversation

VictorOdede
Copy link
Collaborator

PR for Issue #2

  • Updated Rebel and Backward-Chaining agents to use closures for tool API calls
  • Standardized tool interfaces for Rebel and Backward-Chaining agents
  • Added doc strings for all methods Rebel and Backward-Chaining classes

@VictorOdede
Copy link
Collaborator Author

Hi @mmirman. Started working on issue #2. Kindly review my PR.

@abhigya-sodani
Copy link
Collaborator

This looks great! Ran the agents on my laptop, REBEL has some issues that I will fix (I have made some changes to the original algorithm that the original author of the branch was not aware of). Merging this into the feature/LLM-VM-add-agents branch and I will work on my fixes there

@abhigya-sodani abhigya-sodani merged commit dc96b5b into anarchy-ai:feature/LLM-VM-add-agents Jun 28, 2023
@VictorOdede
Copy link
Collaborator Author

Thanks @abhigya-sodani! Looking forward to working on some more tasks. How do I collect the bounty for this task?

@mmirman
Copy link
Contributor

mmirman commented Jun 29, 2023

What is your email and I'll send you a message there.

@VictorOdede
Copy link
Collaborator Author

My email is victorch9@gmail.com.

@mmirman
Copy link
Contributor

mmirman commented Jun 29, 2023

Correct me if I'm wrong but from ticket #2 looks like this addresses points:

  • These need a standardized interface (so they take tool descriptions of the same format),
  • They should also be updated to use non-api tools (just closures).

Partially addresses:

  • Standardized documentation

And does not address:

  • to be updated to use the optimizing completion API,
  • test suites that actually work.

I'll pay out half for this ticket then and spin out a new ticket for the rest.

@VictorOdede
Copy link
Collaborator Author

Thanks for the task breakdown. Wasn't sure whether I had covered the entire scope of the task. I'll work on updating the agents to use the optimizing completion endpoint and adding the test suites. Is it okay if I implement the tests using Pytest?

@mmirman
Copy link
Contributor

mmirman commented Jun 29, 2023

Lets wait for @abhigya-sodani to finish the merge and add current test suits and results so we've got a regression for the rest. The necessary tests aren't pytest style tests, they are from the ICML conference submission.

@VictorOdede
Copy link
Collaborator Author

Sure! Although I'm not too familiar with the ICML submission, do you mind sharing some documentation on this?

@abhigya-sodani
Copy link
Collaborator

There are some small issues with the REBEL agent, so I think I can take over the remainder of this ticket, but your help really sped things up for me!

Are you on the discord, you can find the link the to discord here https://github.com/anarchy-ai. Once you are on the discord it will be easy for us to coordinate your next ticket to work on!

@VictorOdede
Copy link
Collaborator Author

Great, glad I could help.

I already joined the Anarchy discord. Will reach out on the Engineering channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants